fix: return redirect errors early #1003

kangmingtay · 2024-12-16T17:55:10Z

What kind of change does this PR introduce?

Fixes the bug introduced previously in https://github.com/supabase/auth-js/pull/993/files#diff-3522461172efd6058d6b8da62fc2d30d8b524d2b64894ea2c67218c52f7fdff5R310, where it attempted to always try to find a session in the URL, which led to users being logged out on a page refresh
This PR also reverts the previous PR fix: return error early for redirects #992, which returns the error early if there's a redirect, since some redirect errors (like identity linking) should not result in the existing session being removed.
Tested the following scenarios:
- Sign in and refresh the page
- Sign in and attempt to link an already existing identity
- Sign in and attempt to link a new identity

This reverts commit 12b2848.

🤖 I have created a release *beep* *boop* --- ## [2.67.3](v2.67.2...v2.67.3) (2024-12-17) ### Bug Fixes * return redirect errors early ([#1003](#1003)) ([9751b80](9751b80)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

kangmingtay added 2 commits December 14, 2024 15:54

fix: revert "fix: revert #992 and #993 (#999)"

ddee8f4

This reverts commit 12b2848.

fix: don't remove session if it's not a valid callback url type

627b1d4

kangmingtay changed the title ~~fix: get session from url~~ fix: return redirect errors early Dec 16, 2024

J0 approved these changes Dec 17, 2024

View reviewed changes

kangmingtay merged commit 9751b80 into master Dec 17, 2024
7 checks passed

kangmingtay deleted the km/fix-get-session-from-url branch December 17, 2024 09:26

github-actions bot mentioned this pull request Dec 17, 2024

chore(master): release 2.67.3 #1005

Merged