Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question]: Shouldn't HttpRequestException subclass IOException? #846

Closed
1 task done
sproctor opened this issue Feb 1, 2025 · 1 comment · Fixed by #847
Closed
1 task done

[Question]: Shouldn't HttpRequestException subclass IOException? #846

sproctor opened this issue Feb 1, 2025 · 1 comment · Fixed by #847
Assignees
@jan-tennert
Labels
question Further information is requested

Comments

@sproctor
Copy link

sproctor commented Feb 1, 2025

General info

What is your question?

That would allow handling all network errors in the IOException handler. Currently, HttpRequestTimeoutException needs to be handled separately.

Relevant log output (optional)


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @sproctor
sproctor




          added
  the 

  question

  Further information is requested
 label


      Feb 1, 2025

    

  



    

    

      
    

    


      

          @jan-tennert
jan-tennert




              self-assigned this


      Feb 2, 2025

    

  



  

  

    
  


  

      

    @jan-tennert
jan-tennert



    mentioned this issue
    
      Feb 2, 2025
    





  


  

      
   Merged

  







  









      

  
      



  

  @jan-tennert





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

  





      


        


  
    

      
          
Hi, yes the HttpRequestException should subclass IOException. Opened up a PR.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @jan-tennert
  
    jan-tennert
    

      








      


  


  

    Labels
  



    

      

    question

  Further information is requested








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      Make HttpRequestException inherit from IOException

    
      supabase-community/supabase-kt
    





    
  




      

    

  
      

  

    

      2 participants
    

    

        
          @sproctor 
        
          @jan-tennert