Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use FRAGMENT identifiers instead of QUERY identifiers #11

Closed
laralove143 opened this issue May 24, 2024 · 4 comments
Closed

use FRAGMENT identifiers instead of QUERY identifiers #11

laralove143 opened this issue May 24, 2024 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@laralove143
Copy link

this is a quote from this pr comment: twilight-rs/twilight#2348 (comment)

@sunsided
Copy link
Owner

sunsided commented May 24, 2024

Thanks for bringing that up. I saw the comment yesterday, but it seems to address something different.

The fragment is the part after the # (and not meant to be sent to a server).

image

I also updated the encoding in 0.4.2 with some extensions (specifically, encoding #, = etc.) even though not strictly required by RFC 3986.

Also from https://url.spec.whatwg.org/#query-percent-encode-set:

image

@sunsided sunsided self-assigned this May 24, 2024
@sunsided sunsided added the question Further information is requested label May 24, 2024
@sunsided
Copy link
Owner

... thinking about it, it seems the comment suggests that the original version incorrectly uses fragment-specific encoding when it shouldn't. Does this affect this library (particularly after 0.4.2)?

@Erk-
Copy link

Erk- commented May 24, 2024

I think after the change made in b403c6d it is no longer an issue. Thanks for the quick turnaround.

@sunsided
Copy link
Owner

Gladly! I'll close this for the time being, but feel free to follow up if more work is needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants