Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/auth/register should have the option to mask response to prevent existing users from being discovered #213

Open
oliver-zhou opened this issue Jul 11, 2017 · 2 comments

Comments

@oliver-zhou
Copy link
Contributor

oliver-zhou commented Jul 11, 2017

If for example, I'm using email addresses as the Username, I wouldn't want the system to respond that "A user with that username already exists.". It's the same problem that PASSWORD_RESET_SHOW_EMAIL_NOT_FOUND is trying to solve

Created a version controlling the response and email behavior in this situation - need to add some tests before creating a pull request.

@oliver-zhou oliver-zhou changed the title /auth/register should have the option to not respond if username already exists /auth/register should have the option to mask response to prevent existing users from being discovered Jul 12, 2017
@pszpetkowski
Copy link
Contributor

pszpetkowski commented Jul 14, 2017

I wouldn't want the system to respond that "A user with that username already exists."

Could you provide some background on the issue? Is it security or something else?

@oliver-zhou
Copy link
Contributor Author

For security : for those with Username == Email, we should give the developer the option to hide from the user that "Username is not found"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants