Adds shape property to NDCube #684

CyclingNinja · 2024-04-23T14:43:58Z

Deprecates the dimensions property

Depricates `dimensions` property

DanRyanIrish

Comments regarding NDCubeSequence: As well as request changes, make NDCubeSequence.dimensions do this:

def dimensions(self):
    return tuple([d * u.pix for d in self._shape])

Also, create a .shape property that just returns self._shape.

It's possible this may cause breaks elsewhere...

ndcube/ndcube_sequence.py

Co-authored-by: DanRyanIrish <[email protected]>

ndcube/ndcube_sequence.py

ndcube/ndcube.py

ndcube/utils/exceptions.py

Co-authored-by: Nabil Freij <[email protected]>

Co-authored-by: DanRyanIrish <[email protected]>

Co-authored-by: Nabil Freij <[email protected]>

ndcube/ndcube_sequence.py

ndcube/ndcube.py

ndcube/ndcube_sequence.py

Depricates `dimensions` property

Co-authored-by: Nabil Freij <[email protected]>

Co-authored-by: DanRyanIrish <[email protected]>

Co-authored-by: Nabil Freij <[email protected]>

changelog/684.breaking.rst

…o remove_dimension

Co-authored-by: DanRyanIrish <[email protected]>

ndcube/extra_coords/tests/test_extra_coords.py

ndcube/ndcube.py

ndcube/ndcube_sequence.py

ndcube/tests/test_ndcubesequence.py

Co-authored-by: DanRyanIrish <[email protected]>

CyclingNinja added 2 commits April 23, 2024 15:40

Implements new shape property on class

8467e17

Depricates `dimensions` property

Merge branch 'main' of github.com:sunpy/ndcube into remove_dimension

32b58c4

CyclingNinja force-pushed the remove_dimension branch from bd06799 to 32b58c4 Compare April 23, 2024 14:53

DanRyanIrish requested changes Apr 23, 2024

View reviewed changes

ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved

ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved

ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved

CyclingNinja and others added 5 commits April 23, 2024 15:58

Update ndcube/ndcube_sequence.py

4e251f8

Co-authored-by: DanRyanIrish <[email protected]>

Update ndcube/ndcube_sequence.py

6f18309

Co-authored-by: DanRyanIrish <[email protected]>

Update ndcube/ndcube_sequence.py

859690b

Co-authored-by: DanRyanIrish <[email protected]>

Adds shape property to NDCubeSequence

4e58b82

Adds exceptions package

9151f76

DanRyanIrish requested changes Apr 24, 2024

View reviewed changes

ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved

nabobalis reviewed Apr 24, 2024

View reviewed changes

ndcube/ndcube.py Outdated Show resolved Hide resolved

nabobalis reviewed Apr 24, 2024

View reviewed changes

ndcube/ndcube.py Outdated Show resolved Hide resolved

nabobalis reviewed Apr 24, 2024

View reviewed changes

ndcube/utils/exceptions.py Outdated Show resolved Hide resolved

nabobalis reviewed Apr 24, 2024

View reviewed changes

ndcube/utils/exceptions.py Outdated Show resolved Hide resolved

CyclingNinja and others added 6 commits April 24, 2024 10:11

Update ndcube/utils/exceptions.py

9176883

Co-authored-by: Nabil Freij <[email protected]>

Update ndcube/utils/exceptions.py

237a349

Co-authored-by: Nabil Freij <[email protected]>

Update ndcube/ndcube_sequence.py

b3067b5

Co-authored-by: DanRyanIrish <[email protected]>

Update ndcube/ndcube.py

5f9d832

Co-authored-by: Nabil Freij <[email protected]>

Update ndcube/ndcube.py

616c111

Co-authored-by: Nabil Freij <[email protected]>

Merge branch 'main' of github.com:sunpy/ndcube into remove_dimension

8ead4c7

DanRyanIrish reviewed Apr 24, 2024

View reviewed changes

ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved

nabobalis reviewed Apr 24, 2024

View reviewed changes

ndcube/ndcube.py Outdated Show resolved Hide resolved

nabobalis reviewed Apr 24, 2024

View reviewed changes

ndcube/ndcube.py Outdated Show resolved Hide resolved

nabobalis reviewed Apr 24, 2024

View reviewed changes

ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved

nabobalis reviewed Apr 24, 2024

View reviewed changes

ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved

nabobalis reviewed Apr 24, 2024

View reviewed changes

ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved

Implements deprecation warnings on dimensions

c8676c2

nabobalis added this to the 2.3.0 milestone Apr 24, 2024

CyclingNinja force-pushed the remove_dimension branch from 8a9d566 to c8676c2 Compare April 24, 2024 09:29

Implements new shape property on class

2d66db6

Depricates `dimensions` property

CyclingNinja and others added 7 commits April 24, 2024 11:29

Update ndcube/utils/exceptions.py

b941d22

Co-authored-by: Nabil Freij <[email protected]>

Update ndcube/utils/exceptions.py

ca9c8b2

Co-authored-by: Nabil Freij <[email protected]>

Update ndcube/ndcube_sequence.py

2c5542f

Co-authored-by: DanRyanIrish <[email protected]>

Update ndcube/ndcube.py

e64670a

Co-authored-by: Nabil Freij <[email protected]>

Update ndcube/ndcube.py

59d2e30

Co-authored-by: Nabil Freij <[email protected]>

Implements deprecation warnings on dimensions

e186d53

add changelog

69d2cf1

nabobalis force-pushed the remove_dimension branch from c8676c2 to 69d2cf1 Compare April 24, 2024 09:30

nabobalis added 2 commits April 24, 2024 11:32

add changelog v2

22bd1b3

Apply suggestions from code review

642dd89

nabobalis requested a review from DanRyanIrish April 24, 2024 09:34

DanRyanIrish reviewed Apr 24, 2024

View reviewed changes

changelog/684.breaking.rst Outdated Show resolved Hide resolved

CyclingNinja and others added 7 commits April 24, 2024 10:50

Applies dimension -> shape refactor

f7ee5ee

Merge branch 'remove_dimension' of github.com:CyclingNinja/ndcube int…

b23be65

…o remove_dimension

First set of changes

ba18115

Update changelog/684.breaking.rst

494daaa

Co-authored-by: DanRyanIrish <[email protected]>

Second set of changes - Broken like my heart

c861ab8

Third set of changes

26605d2

Final set of changes

ec430bd

DanRyanIrish reviewed Apr 24, 2024

View reviewed changes

ndcube/extra_coords/tests/test_extra_coords.py Outdated Show resolved Hide resolved

DanRyanIrish reviewed Apr 24, 2024

View reviewed changes

ndcube/ndcube.py Show resolved Hide resolved

Merge remote-tracking branch 'upstream/main' into pr/684

2716bff

DanRyanIrish reviewed Apr 24, 2024

View reviewed changes

ndcube/ndcube_sequence.py Show resolved Hide resolved

Bugfixes due to review

d5eb23c

nabobalis closed this Apr 24, 2024

nabobalis reopened this Apr 24, 2024

DanRyanIrish requested changes Apr 24, 2024

View reviewed changes

Apply suggestions from code review

8ed4e5f

Co-authored-by: DanRyanIrish <[email protected]>

DanRyanIrish approved these changes Apr 24, 2024

View reviewed changes

DanRyanIrish merged commit 6d1473c into sunpy:main Apr 24, 2024
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds shape property to NDCube #684

Adds shape property to NDCube #684

CyclingNinja commented Apr 23, 2024

DanRyanIrish left a comment

Adds shape property to NDCube #684

Adds shape property to NDCube #684

Conversation

CyclingNinja commented Apr 23, 2024

DanRyanIrish left a comment

Choose a reason for hiding this comment