Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable partial indent with leading ~ #518

Conversation

mkantor
Copy link
Contributor

@mkantor mkantor commented Jul 16, 2022

In handlebars.js, {{~> partial}} disables indentation for every line of partial content. However, the handebars-rust indent support added in #505 did not work this way, with ~ instead only removing the indent from the first line. This changeset fixes that, bringing handlebars-rust behavior closer to handlebars.js.

@mkantor mkantor force-pushed the omit-pre-whitespace-prevents-multiline-partial-indent branch from 0448052 to 32bc309 Compare July 16, 2022 21:20
@mkantor
Copy link
Contributor Author

mkantor commented Jul 16, 2022

Looks like the CI failure with nightly will be fixed by rust-lang/rust#99263.

Copy link
Owner

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this patch!

@sunng87
Copy link
Owner

sunng87 commented Jul 17, 2022

I'll merge this let cron based CI to check this when new nightly is available

@sunng87 sunng87 merged commit 29fef48 into sunng87:master Jul 17, 2022
@mkantor mkantor deleted the omit-pre-whitespace-prevents-multiline-partial-indent branch July 17, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants