Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax rails dependency #78

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Relax rails dependency #78

merged 1 commit into from
Jan 2, 2020

Conversation

MaximeD
Copy link
Contributor

@MaximeD MaximeD commented Dec 31, 2019

This relax the rails dependency to allow subversions of rails 6.0 to
use the gem.

In order to simplify the dependencies of the lib, instead of requiring
all rails, just the relevant part are required.

Travis has also been updated to run on rubies 2.5 and 2.6.

@coveralls
Copy link

coveralls commented Dec 31, 2019

Coverage Status

Coverage decreased (-0.02%) to 98.856% when pulling cbfb03a on MaximeD:relax_rails_6_dependency into 45bba17 on sungwoncho:master.

@chevinbrown
Copy link
Contributor

This relax the rails dependency to allow subversions of rails 6.0 to
use the gem.

Travis has also be updated to run on rubies 2.5 and 2.6.

Nice ❤️.
Why the manifest changes?

@MaximeD
Copy link
Contributor Author

MaximeD commented Dec 31, 2019

Thanks 😄
The manifest was added because it is required by sprockets 4, which was updated when I did a new bundle after relaxing rails’ dependency.
But not sure that won’t do as latest sprockets requires ruby >= 2.5, so that might break for users still using ruby 2.4. I’ll try to see if I can relax the dependency without having sprockets upgrading itself 🤔

@chevinbrown
Copy link
Contributor

Thanks 😄
The manifest was added because it is required by sprockets 4, which was updated when I did a new bundle after relaxing rails’ dependency.
But not sure that won’t do as latest sprockets requires ruby >= 2.5, so that might break for users still using ruby 2.4. I’ll try to see if I can relax the dependency without having sprockets upgrading itself 🤔

Makes sense! Really, sprockets shouldn't be a dependency...I only passively maintain this gem as an artifact of my last job. 😢
Either way, I can accept this change if you're not able to keep it slim.

This relax the rails dependency to allow subversions of rails `6.0` to
use the gem.

In order to simplify the dependencies of the lib, instead of requiring
all rails, just the relevant part are required.

Travis has also been updated to run on rubies 2.5 and 2.6.
@MaximeD
Copy link
Contributor Author

MaximeD commented Jan 1, 2020

So in the end, I changed the dependencies to only require the parts of rails that are really needed by this gem. This way no need for sprockets anymore!

Let me know :)

@chevinbrown
Copy link
Contributor

@MaximeD fantastic!

@chevinbrown chevinbrown merged commit 4ca15cb into has-friendship:master Jan 2, 2020
@MaximeD
Copy link
Contributor Author

MaximeD commented Jan 2, 2020

Awesome, thank you!

@MaximeD MaximeD deleted the relax_rails_6_dependency branch January 2, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants