Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run callbacks on state change #41

Merged
merged 1 commit into from
May 6, 2017
Merged

Run callbacks on state change #41

merged 1 commit into from
May 6, 2017

Conversation

sbadura
Copy link
Contributor

@sbadura sbadura commented May 2, 2017

Add ability to create own callbacks.

@sbadura sbadura mentioned this pull request May 2, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.789% when pulling 9a3a794 on sbadura:master into 2718e53 on sungwoncho:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.789% when pulling e5fd7b2 on sbadura:master into 2718e53 on sungwoncho:master.

@temkin
Copy link

temkin commented May 5, 2017

@sungwoncho could you accept this PR?

@sungwoncho
Copy link
Collaborator

sungwoncho commented May 6, 2017 •
edited
Loading

@temkin sorry for the delay.

This looks useful. @sbadura would you mind adding a test and document it in the README for those wanting to use this feature?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.796% when pulling 7afc5f1 on sbadura:master into 2718e53 on sungwoncho:master.

@sbadura
Copy link
Contributor Author

sbadura commented May 6, 2017

@sungwoncho Done :)

@sungwoncho sungwoncho merged commit 7770e28 into has-friendship:master May 6, 2017
@sungwoncho
Copy link
Collaborator

sungwoncho commented May 6, 2017 •
edited
Loading

Released in v1.1.0. ping @temkin.

Thanks for the PR.

@temkin
Copy link

temkin commented May 8, 2017

@sungwoncho thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbadura @coveralls @temkin @sungwoncho