Fix friends_with to return only true when friendship is accepted. Fix #…

…21

lib/has_friendship/friendable.rb

@@ -85,7 +85,7 @@ def on_relation_with(friend)
       end
 
       def friends_with?(friend)
-        HasFriendship::Friendship.find_relation(self, friend).any?
+        HasFriendship::Friendship.find_relation(self, friend, status: 'accepted').any?
       end
 
       private

lib/has_friendship/friendship.rb

@@ -1,11 +1,17 @@
 module HasFriendship
   class Friendship < ActiveRecord::Base
-    def self.relation_attributes(one, other)
-      {
+    def self.relation_attributes(one, other, status: nil)
+      attr = {
         friendable_id: one.id,
         friendable_type: one.class.base_class.name,
         friend_id: other.id
       }
+
+      if status
+        attr[:status] = status
+      end
+
+      attr
     end
 
     def self.create_relation(one, other, options)
@@ -14,8 +20,8 @@ def self.create_relation(one, other, options)
       relation.save
     end
 
-    def self.find_relation(friendable, friend)
-      where relation_attributes(friendable, friend)
+    def self.find_relation(friendable, friend, status: nil)
+      where relation_attributes(friendable, friend, status: status)
     end
 
     def self.exist?(friendable, friend)

spec/has_friendship/friendable_spec.rb

@@ -249,6 +249,20 @@
           expect(jon.friends_with?(user)).to eq false
         end
       end
+
+      context 'when a pending friendship exists' do
+        it 'returns false' do
+          create_friendship(user, friend, status: 'pending')
+          expect(user.friends_with?(friend)).to eq false
+        end
+      end
+
+      context 'when a blocked friendship exists' do
+        it 'returns false' do
+          create_friendship(user, friend, status: 'blocked')
+          expect(user.friends_with?(friend)).to eq false
+        end
+      end
     end
   end
 end