Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stylelint to lint CSS #916

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Add Stylelint to lint CSS #916

merged 2 commits into from
Dec 1, 2023

Conversation

connor-baer
Copy link
Member

Purpose

SumUp is slowly replacing Emotion.js with CSS Modules. One benefit of writing vanilla CSS in separate files is that we can use Stylelint to catch errors and enforce a consistent code style.

Approach and changes

  • Install Stylelint and some plugins
  • Create a sensible base config

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

@connor-baer connor-baer requested a review from a team as a code owner December 1, 2023 23:11
@connor-baer connor-baer requested review from tareqlol and removed request for a team December 1, 2023 23:11
Copy link

changeset-bot bot commented Dec 1, 2023

🦋 Changeset detected

Latest commit: 2cf9d8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ebbb437) 68.01% compared to head (2cf9d8c) 68.91%.

Files Patch % Lines
src/configs/stylelint/config.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
+ Coverage   68.01%   68.91%   +0.90%     
==========================================
  Files          18       19       +1     
  Lines         372      386      +14     
  Branches       63       67       +4     
==========================================
+ Hits          253      266      +13     
- Misses        110      111       +1     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer changed the title Add Stylelint Add Stylelint to lint CSS Dec 1, 2023
@connor-baer connor-baer merged commit b3b5cfe into main Dec 1, 2023
7 checks passed
@connor-baer connor-baer deleted the feature/stylelint branch December 1, 2023 23:24
@connor-baer connor-baer mentioned this pull request Dec 1, 2023
@connor-baer connor-baer mentioned this pull request Feb 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant