Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): migrate Tag to TypeScript #654

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Conversation

connor-baer
Copy link
Member

Addresses #516.

Approach and changes

  • migrate Tag component to TypeScript

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

feature/typescript-tag

feature/typescript-tag
@connor-baer connor-baer added the feature A new feature or enhancement label Jul 27, 2020
@connor-baer connor-baer added this to the v2.0 milestone Jul 27, 2020
@vercel
Copy link

vercel bot commented Jul 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/l417q80g5
✅ Preview: https://circuit-ui-git-feature-typescript-tag.sumup-oss.vercel.app

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #654 into beta will decrease coverage by 0.20%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta     #654      +/-   ##
==========================================
- Coverage   94.08%   93.88%   -0.21%     
==========================================
  Files         131      131              
  Lines        2232     2239       +7     
  Branches      622      623       +1     
==========================================
+ Hits         2100     2102       +2     
- Misses        110      113       +3     
- Partials       22       24       +2     
Impacted Files Coverage Δ
src/components/Tag/Tag.tsx 97.56% <97.56%> (ø)
src/components/Button/Button.tsx 100.00% <100.00%> (ø)
src/components/Input/Input.tsx 100.00% <100.00%> (ø)
src/util/shared-prop-types.js 47.05% <0.00%> (-41.18%) ⬇️
...omponents/CalendarTagTwoStep/CalendarTagTwoStep.js 61.22% <0.00%> (+2.04%) ⬆️
src/components/CalendarTag/CalendarTag.js 61.76% <0.00%> (+2.94%) ⬆️

@connor-baer connor-baer merged commit 3fed6ef into beta Jul 27, 2020
@connor-baer connor-baer deleted the feature/typescript-tag branch July 27, 2020 09:37
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0-beta.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant