perf: reduce dependencies #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## alpha #601 +/- ##
==========================================
- Coverage 94.26% 94.14% -0.13%
==========================================
Files 136 135 -1
Lines 2198 2203 +5
Branches 631 633 +2
==========================================
+ Hits 2072 2074 +2
- Misses 103 105 +2
- Partials 23 24 +1
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/iitfxymln |
feature/polish-v2
connor-baer
force-pushed
the
feature/reduce-dependencies
branch
from
ff7ab8c to
de6d438
Compare
feature/reduce-dependencies
connor-baer
force-pushed
the
feature/reduce-dependencies
branch
from
de6d438 to
5df57a7
Compare
fernandofleury
approved these changes
Jun 4, 2020
|
🎉 This PR is included in version 2.0.0-alpha.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In order to decrease bundle size, we should reduce the number of dependencies we rely on. Third-party packages tend to include more code than we need. Tree-shaking solves some of that, but in some cases, we can simply move the needed code into Circuit UI.
Approach and changes
hideVisuallystyle helperBREAKING CHANGE: The static size properties have been removed from the CardList.Item component. Pass the size as a string instead.
Definition of done