Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System requirements for PHP are confusing (8.0 vs. 8.1) #217

Open
froschdesign opened this issue Apr 14, 2023 · 4 comments
Open

System requirements for PHP are confusing (8.0 vs. 8.1) #217

froschdesign opened this issue Apr 14, 2023 · 4 comments

Comments

@froschdesign
Copy link

froschdesign commented Apr 14, 2023

Q A
Bug? maybe
New Feature? no
Sulu Version 2.5.x / latest
Browser Version irrelevant

Actual Behavior

The skeleton requires PHP version 8.1 and higher:

skeleton/composer.json

Lines 29 to 30 in eb5158c

"require": {
"php": "^8.1",

Sulu itself allows version 8.0 and higher:

https://github.com/sulu/sulu/blob/097a23c376f1fddbcdfdbd4f564f7847ec0cc934/composer.json#L27-L28

The documentation says PHP 8.0 and higher:

The following requirements must be met to run Sulu:

  • Mac OSX, Linux or Windows
  • Apache or Nginx with enabled URL rewriting
  • PHP 8.0 or higher

https://docs.sulu.io/en/2.5/reference/requirements.html

Expected Behavior

If Sulu allows version 8 of PHP and the documentation also lists this version under the system requirements, then the skeleton should allow the same version.

Steps to Reproduce

See above.

Possible Solutions

Update the Composer configuration of this package.

@alexander-schranz
Copy link
Member

Thank you for the feedback.

Why sulu/sulu still supports PHP 8.0. The skeleton and new installation is shipped with latest Symfony Version which requires atleast PHP 8.1. So at current state you can use PHP 8.0 to run latest version of Sulu and old projects on PHP 8 can update to that latest version, but you can not start a new project based on the skeleton because Symfony 6.1 (6.2 is used in 2.5 skeleton) requires now PHP 8.1: https://symfony.com/blog/symfony-6-1-will-require-php-8-1

So looking here I think we should update the docs to set the requirement to PHP 8.1 there for Sulu 2.5. Do you want to create a pull request for it?

@froschdesign
Copy link
Author

I found another notice:

✅  Requirements

Sulu requires a PHP version higher or equal to 8.0 and is compatible with every Symfony version starting from 5.4. Have a look at the require section in the composer.json of the sulu/sulu core framework to find an up-to-date list of the requirements of Sulu content management system.

https://github.com/sulu/sulu#-requirements

@froschdesign
Copy link
Author

froschdesign commented Apr 14, 2023

Why sulu/sulu still supports PHP 8.0. The skeleton and new installation is shipped with latest Symfony Version which requires atleast PHP 8.1.

Okay, that explains it, but it's not clear when you read the documentation, because it says version 8.0 and refers to the skeleton.

Do you want to create a pull request for it?

I will create a pull request on https://github.com/sulu/sulu-docs

@alexander-schranz
Copy link
Member

Yeah think change the docs that requirement is PHP 8.1 make sense as people reading that are mostly the ones which starting a new project and not working on an existing one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants