-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exhibits/prod] NoMethodError: undefined method `exhibit_feature_page_path' for an instance of Spotlight::BreadcrumbsComponent #2638
[exhibits/prod] NoMethodError: undefined method `exhibit_feature_page_path' for an instance of Spotlight::BreadcrumbsComponent #2638
Comments
Looking at the backtrace for this particular error: the error is occurring in the context of item pages in the OSS maps exhibit. Clicking on an item from https://exhibits.stanford.edu/oss-maps/about/reports takes me directly to the system status page for now. The honeybadger error says this URL is throwing the error: https://exhibits.stanford.edu/oss-maps/catalog/mc719gp8838 . I also tried another item from the exhibit and saw the same error: https://exhibits.stanford.edu/oss-maps/catalog/wn154qv6802 |
I patched the spotlight breadcrumbs component in an exhibits branch to rescue from any errors raised when attempting to create a path for a breadcrumb: https://github.com/sul-dlss/exhibits/compare/breadcrumb-test?expand=1 There's definitely a problem for some exhibits with this method of creating a link but I'm having a hard time duplicating it on stage or in my development environment. I think this is also the source of the problem reported by Andrew the other day with the Stanford Band collection. |
@hudajkhan @dnoneill it looks like there's a problem with breadcrumbs on pages that use the saved search widget. The breadcrumb entry that gets saved doesn't resolve to a route in the app. This is a bug in spotlight. |
Fix was due to me using the wrong way to compute path. I looked at how breadcrumb_rails did this and updated it to use the else in here: https://github.com/weppos/breadcrumbs_on_rails/blob/4e74436c0f3f5cdc16d05de92b67d97a45ba545a/lib/breadcrumbs_on_rails/breadcrumbs.rb#L56C7-L65C10. From what I can tell spotlight isn't using Proc or Symbols so I don't think we need to add it back in. |
Backtrace
View full backtrace and more info at honeybadger.io
The text was updated successfully, but these errors were encountered: