Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize display logic for all facets #1647

Open
jacobthill opened this issue Feb 7, 2023 · 1 comment
Open

Standardize display logic for all facets #1647

jacobthill opened this issue Feb 7, 2023 · 1 comment
Labels

Comments

@jacobthill
Copy link
Contributor

Some facets in DLME, like 'Type' and 'Language' have language specific display logic e.g. if a record has values 'Type' for Arabic and English, it displays only the English ones when the user is navigating the English view, and only the Arabic ones when the user is navigating in the Arabic view. This is the desirable behavior for all facets, if possible.

Other facets like 'Spatial' will display Arabic and English values for the same record in both views e.g. https://dlmenetwork.org/en/library/catalog?f%5Bagg_data_provider_en%5D%5B%5D=British+Library.+India+Office+Records+and+Private+Papers&f%5Bcho_type_facet.ar-Arab_ssim%5D%5B%5D=%D9%86%D8%B5%3A%D9%85%D8%B3%D9%84%D8%B3%D9%84%D8%A7%D8%AA&f%5Bspatial%5D%5B%5D=%D8%A7%D9%84%D8%AE%D9%84%D9%8A%D8%AC+%D8%A7%D9%84%D8%B9%D8%B1%D8%A8%D9%8A&f%5Bspatial%5D%5B%5D=Persian+Gulf&per_page=96

Ideally, all facets could work like 'Type' and 'Language', but there may be a reason they don't work that way. The data for 'Type' and 'Language' is very consistent; there is always an Arabic and an English value. The data for other fields may sometimes have Arabic, sometimes English, sometimes another language, sometimes multiple languages, etc. If the inconsistency does not prevent us, we should display Arabic script values in the Arabic view and Latin script values in the English view.

I'm happy to talk through this if needed.

@thatbudakguy
Copy link
Member

Still some big questions about how this should work, since BL thinks that the two language versions of a facet are different values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants