Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print <-- Current Pitch does not Concat with Text String when inside a Note #2939

Closed
pikurasa opened this issue May 5, 2021 · 3 comments · Fixed by #2946
Closed

Print <-- Current Pitch does not Concat with Text String when inside a Note #2939

pikurasa opened this issue May 5, 2021 · 3 comments · Fixed by #2946

Comments

@pikurasa
Copy link
Collaborator

pikurasa commented May 5, 2021

Perhaps this issue is related to #2935 , however #2938 does not fix it.

If you have Print <-- Current Pitch and concatenate a text string, the program fails completely.

Interestingly, the issue only occurs with the Print <-- Current Pitch block is inside of a note. Outside of a note, it works.

Screenshot at 2021-05-04 20:42:04

Uncaught TypeError: Cannot read property 'toString' of undefined
    at Function.doPlus (mathutils.js:160)
    at PlusBlock.arg (NumberBlocks.js:710)
    at Logo.parseArg (logo.js:833)
    at Logo.runFromBlockNow (logo.js:1546)
    at logo.js:1504

Test File
Concat-broken.html.zip

@daksh4469
Copy link
Member

I tried fixing this by adding a check for undefined arguments in the doPlus method and it worked. The end result is shown in the video below.

concat.mp4

Can you please confirm if this is the desired behavior? @pikurasa
Thanks.

@walterbender
Copy link
Member

fixed as part of ae7ce91

@daksh4469
Copy link
Member

I think this issue still persists. I have a possible fix (#2946) for this but was waiting for confirmation on my earlier comment.
Please review the patch @walterbender.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants