Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review for CS-1016 #2

Open
jwelborn-sugar opened this issue Oct 27, 2020 · 2 comments
Open

Code Review for CS-1016 #2

jwelborn-sugar opened this issue Oct 27, 2020 · 2 comments

Comments

@jwelborn-sugar
Copy link
Contributor

jwelborn-sugar commented Oct 27, 2020

I think if this is the only time we use underscore, can we use Object.assign() and not add a dependency?

If we're going to possibly use these env options, should we go ahead and include them as template parameters?

@sugarhqi
Copy link
Contributor

I included underscore mainly because we are using it for frontend, so I guess everybody is used to it and people may need it in other lambda functions.

As for platform and cliend_id, should we hard code them instead? beacuse we dont want customers to use random values?

@jwelborn-sugar
Copy link
Contributor Author

underscore makes sense. Everyone knows it.

for client_id and platform, I think the fallback value for clientId is fine. I guess I'm just surprised the API call with an empty platform is working and not failing platform validation in the Sugar API. Did I maybe miss the value getting added somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants