Skip to content
This repository has been archived by the owner on Mar 3, 2024. It is now read-only.

Not working without learna #46

Open
flyingnobita opened this issue Aug 5, 2021 · 4 comments
Open

Not working without learna #46

flyingnobita opened this issue Aug 5, 2021 · 4 comments

Comments

@flyingnobita
Copy link

flyingnobita commented Aug 5, 2021

I'm trying to follow the instructions and I'm not using lerna and to "Manually call precommit in each package".

I'm following the instructions in section "Manually call precommit in each package", where I have a .lintstagedrc.yml in each project's own folder. lint-staged and husky has been installed at the project root. I've got husky setup with npm-run-all and husky is working with the precommit hook.

However, my hook doesn't seem to get called when I stage my files.

I think I'm missing some more configuration. Can you please provide more details on your instructions for the section "Manually call precommit in each package"?

Thank you very much!

@sudo-suhas
Copy link
Owner

Don't have any additional instructions that I could share. If you could share a minimal repo that can be used to reproduce the issue, I can try to take a look.

@flyingnobita
Copy link
Author

flyingnobita commented Aug 7, 2021

Can you clarify that for "Manually call precommit in each package", besides installing husky at project root, I assume lint-staged should also be installed? (as this wasn't explicitly said in this section). Are there other things that need to be installed or configured?

@sudo-suhas
Copy link
Owner

Yes, I think tools used in the pre-commit hook would also need to be installed in each package. I had written down the instructions a few years ago so I do not remember all the details clearly, sorry about that.

@flyingnobita
Copy link
Author

I see, thanks anyways!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants