Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing harness #17

Open
sudara opened this issue Jul 31, 2019 · 0 comments
Open

Improve testing harness #17

sudara opened this issue Jul 31, 2019 · 0 comments

Comments

@sudara
Copy link
Owner

sudara commented Jul 31, 2019

We are currently testing by confirming events are fired by reading log lines. Move to a visually improved html test page which responds to events directly and visual elements turn green when tests passes.

I liked how qunit feels:
image

However, in our case, we need to interact with the DOM to trigger most of the tests we care about properly (did playback succeed, is the next track triggered, etc). So although we could move to some amount of unit tests (for cases where it makes sense to test code in isolation), we are still "doomed" to having a custom page to run selenium against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant