Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme convertor issues #27

Open
shivaenigma opened this issue Jul 18, 2019 · 2 comments
Open

readme convertor issues #27

shivaenigma opened this issue Jul 18, 2019 · 2 comments
Labels

Comments

@shivaenigma
Copy link
Contributor

  • Problem in converting this file . I am not able to find out why it broke. @sudar would be great if you can help debug
  • Screenshots don't support gif/jpg file types
@sudar
Copy link
Owner

sudar commented Jul 27, 2019

@shivaenigma

Just had a quick look at your readme and I am not able to find any issues. What happens when you run it through the convertor? Can you paste it as a gist?

WordPress plugin repo only support jpg/png - https://developer.wordpress.org/plugins/wordpress-org/plugin-assets/#screenshots

Having said that the script as such doesn't restrict by file types for screenshots.

@shivaenigma
Copy link
Contributor Author

I was able to find the issue. If the screenshot caption only has one word the convertor fails. See the attached converted file of the README i gave above (see screenshot section)
out.txt
Looks like NF>1 is causing an issue.

GIFs are supported. Yes, look like code should support. I will see what is breaking

@shivaenigma shivaenigma removed their assignment Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants