Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: index_in has wrong return type #632

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: index_in has wrong return type #632

merged 1 commit into from
Apr 18, 2024

Conversation

amol-
Copy link
Contributor

@amol- amol- commented Apr 18, 2024 •
edited
Loading

index_in is currently declared as returning an int64,
the return type should be i64, as according to
https://substrait.io/types/type_classes/#simple-types
there is no int64 type.

vbarua
vbarua approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I just fixed the argument types being declared incorrectly, but totally missed the return type 😅

Thanks for fixing this 🙇

@richtia richtia merged commit 4cd2089 into substrait-io:main Apr 18, 2024
15 checks passed
@amol- amol- deleted the fix-int64-type branch April 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrobbel mbrobbel mbrobbel approved these changes

@vbarua vbarua vbarua approved these changes

@richtia richtia richtia approved these changes

@jacques-n jacques-n Awaiting requested review from jacques-n jacques-n is a code owner

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

@EpsilonPrime EpsilonPrime Awaiting requested review from EpsilonPrime EpsilonPrime is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amol- @richtia @vbarua @mbrobbel