Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing RelCommon field to WriteRel and DdlRel #591

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

joellubi
Copy link
Contributor

@joellubi joellubi commented Jan 23, 2024

Adding the RelCommon field to WriteRel and DdlRel message types so that they can be handled with the same common functionality as other operators.

Addition of a new field is not a breaking change.

Context from Slack discussion

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @joellubi !

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@westonpace westonpace merged commit d55703a into substrait-io:main Jan 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants