Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add min/max for datetime types #584

Merged
merged 1 commit into from
Jan 8, 2024
Merged

feat: add min/max for datetime types #584

merged 1 commit into from
Jan 8, 2024

Conversation

LeonidChistov
Copy link
Contributor

Add min/max aggregations for datetime types.

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

westonpace
westonpace approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only potential concern I have is that we haven't defined the ordering for intervals very clearly. However, this is already a concern given we allow comparisons for intervals so I don't see any reason to hold this up over that issue.

@EpsilonPrime EpsilonPrime merged commit 5c8fa04 into substrait-io:main Jan 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

@richtia richtia richtia approved these changes

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@jacques-n jacques-n Awaiting requested review from jacques-n jacques-n is a code owner

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@vbarua vbarua Awaiting requested review from vbarua vbarua is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LeonidChistov @CLAassistant @EpsilonPrime @richtia @westonpace