Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: specify nullability for is_not_distinct_from #555

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix!: specify nullability for is_not_distinct_from #555

merged 1 commit into from
Sep 28, 2023

Conversation

vbarua
Copy link
Member

@vbarua vbarua commented Sep 18, 2023 •
edited
Loading

BREAKING CHANGE: nullability of is_not_distinct_from has changed

@vbarua
Copy link
Member Author

vbarua commented Sep 18, 2023 •
edited
Loading

The output of IS NOT DISTINCT FROM is never nullable. This PR updates the definition of the function in the spec to DECLARED_OUTPUT in order to match this behaviour (the default is MIRROR which has a null output if any of the inputs is null).

mbrobbel
mbrobbel approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@mbrobbel mbrobbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be marked as a breaking change.

@vbarua vbarua changed the title fix: specify nullability for is_not_distinct_from fix!: specify nullability for is_not_distinct_from Sep 18, 2023
@EpsilonPrime EpsilonPrime merged commit 30773b2 into main Sep 28, 2023
@EpsilonPrime EpsilonPrime deleted the vbarua/specify-is-not-distinct-from-nullability branch September 28, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrobbel mbrobbel mbrobbel approved these changes

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@jacques-n jacques-n Awaiting requested review from jacques-n jacques-n is a code owner

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

Assignees
No one assigned
Labels
awaiting SMC approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbarua @EpsilonPrime @mbrobbel