-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add extra option for on domain errors in log functions #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a breaking change as a new producer could send this new option to an old consumer which wouldn't know what to do with it.
Otherwise I'm good to go with this PR.
Should we use NULL instead of NONE if the behavior is to return a NULL if a domain error occurs? |
1f53487
to
4768da0
Compare
4768da0
to
d213b13
Compare
Reverted back to using NONE. NULL seems to be a reserved word, so it was causing the yaml extension validation to fail |
c9659b7
to
d213b13
Compare
I do like NULL. You are right it is a reserved word in YAML but you should be able to make it work with quotes: |
d213b13
to
e696310
Compare
This is what I originally wanted to do as well...but putting NULL around quotes seemed a little different than the convention we were following. I'm okay with doing this moving forward so long as everyone else is too. Just made the update |
BREAKING CHANGE: Adding a NULL option to the on_domain_errors.
SQLite returns null for some inputs such as negative infinity