feat: add factorial scalar function #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
force-pushed
the
gil/factorial
branch
2 times, most recently
from
84e7f6a to
a2675d0
Compare
richtia
reviewed
Aug 24, 2022
extensions/functions_arithmetic.yaml
Outdated
| Negative inputs will raise an error. | ||
| impls: | ||
| - args: | ||
| - options: [ SILENT, SATURATE, ERROR ] |
There was a problem hiding this comment.
Should we specify the name for the options here?
- name: overflow
gforsyth
force-pushed
the
gil/factorial
branch
from
a2675d0 to
c4f4494
Compare
gforsyth
force-pushed
the
gil/factorial
branch
from
c4f4494 to
92f78fd
Compare
jvanstraten
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a scalar function definition for
factorial(n)I've opted to only support
i32andi64.