Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add regexp_match_substring, regexp_strpos, and regexp_count_sub… #293

Merged
merged 1 commit into from
Sep 2, 2022
Merged

feat: add regexp_match_substring, regexp_strpos, and regexp_count_sub… #293

merged 1 commit into from
Sep 2, 2022

Conversation

richtia
Copy link
Member

@richtia richtia commented Aug 17, 2022

PR to add remaining regexp string functions

jvanstraten
jvanstraten approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@jvanstraten jvanstraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jvanstraten
jvanstraten requested changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@jvanstraten jvanstraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the review change, but as discussed elsewhere, we should probably add CASE_INSENSITIVE_ASCII for consistency with the case conversion functions.

@richtia richtia force-pushed the remaining_regex_functions branch from d1598bd to 4a3cf22 Compare September 2, 2022 16:07
@richtia
Copy link
Member Author

richtia commented Sep 2, 2022

Sorry for the review change, but as discussed elsewhere, we should probably add CASE_INSENSITIVE_ASCII for consistency with the case conversion functions.

Updated!

@richtia richtia mentioned this pull request Sep 2, 2022
Merged
@richtia richtia requested a review from jvanstraten September 2, 2022 16:42
@jvanstraten jvanstraten merged commit 6b8191f into substrait-io:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanstraten jvanstraten jvanstraten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richtia @jvanstraten