refactor(arithmetic): specify FP overflow and domain options for rema… #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ining ops Addition, substraction, multiplication and division were added before we'd settled on / had conversations around what made sense for floating-point overflow and domain error options. Adding in appropriate overflow options for those four ops and also adding the appropriate domain error option for division. BREAKING CHANGE: Options SILENT, SATURATE, ERROR are no longer valid for use with floating point arguments to add, subtract, multiply or divide
|
Thanks for putting this together @gforsyth ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ining ops
Addition, substraction, multiplication and division were added before we'd settled on / had
conversations around what made sense for floating-point overflow and domain error options. Adding
in appropriate overflow options for those four ops and also adding the appropriate domain error
option for division.
BREAKING CHANGE: Options SILENT, SATURATE, ERROR are no longer valid for use with floating point
arguments to add, subtract, multiply or divide