fix: remove cast function definition #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the `Expression` node has an explicit `Cast` variant that was added in substrait-io#88, the `cast` function definition (added in substrait-io#152) seems redundant. BREAKING CHANGE: Existing plans that are modeling `cast` with this built-in function definition over the expression will not be valid.
almann
changed the title
jvanstraten
approved these changes
Jul 21, 2022
jvanstraten
changed the title
|
Looks good, thanks @almann ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the
Expressionnode has an explicitCastvariant that was added in #88, thecastfunction definition (added in #152) seems redundant.This change is technically breaking as there could be dependent plans that are modeling a
castvia function call over the expression.