-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add functions to yaml #228
Conversation
extensions/functions_comparison.yaml
Outdated
description: Whether a value is in a list of values. | ||
impls: | ||
- args: | ||
- value: any1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant this?
- value: any1 | |
- value: T |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function we need is already covered by OrList expression. Removed this.
I think you're looking for the orlist expression (as opposed to introducing in). For the character matching functions, I suggest you also include all permutations of fixed character, string and varchar combinations. |
Thanks for your comment. Removed in function and added the permutations for starts_with, ends_with, contains. |
Please also update commit title. Should be feat and more specific |
Updated. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. I will update the title to be more explicit when I merge.
This PR added starts_with, ends_with, contains functions to yaml files.