Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add functions to yaml #228

Merged
merged 1 commit into from
Jun 19, 2022
Merged

feat: add functions to yaml #228

merged 1 commit into from
Jun 19, 2022

Conversation

rui-mo
Copy link
Contributor

@rui-mo rui-mo commented Jun 16, 2022

This PR added starts_with, ends_with, contains functions to yaml files.

@rui-mo rui-mo changed the title Add functions to yaml yaml: add functions to yaml Jun 16, 2022
@rui-mo rui-mo changed the title yaml: add functions to yaml chore: add functions to yaml Jun 16, 2022
description: Whether a value is in a list of values.
impls:
- args:
- value: any1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant this?

Suggested change
- value: any1
- value: T

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function we need is already covered by OrList expression. Removed this.

@jacques-n
Copy link
Contributor

I think you're looking for the orlist expression (as opposed to introducing in).

For the character matching functions, I suggest you also include all permutations of fixed character, string and varchar combinations.

@rui-mo
Copy link
Contributor Author

rui-mo commented Jun 17, 2022

I think you're looking for the orlist expression (as opposed to introducing in).

For the character matching functions, I suggest you also include all permutations of fixed character, string and varchar combinations.

Thanks for your comment. Removed in function and added the permutations for starts_with, ends_with, contains.

@jacques-n
Copy link
Contributor

Please also update commit title. Should be feat and more specific

@rui-mo rui-mo changed the title chore: add functions to yaml feat: add functions to yaml Jun 17, 2022
@rui-mo
Copy link
Contributor Author

rui-mo commented Jun 17, 2022

Please also update commit title. Should be feat and more specific

Updated. Thank you.

Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. I will update the title to be more explicit when I merge.

@jacques-n jacques-n merged commit a5fa851 into substrait-io:main Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants