From e8b85dd8c5bc23c36e03d3eba5e1823b125b20e6 Mon Sep 17 00:00:00 2001 From: Anshul Data Date: Fri, 4 Oct 2024 16:33:42 +0530 Subject: [PATCH] address review comments --- proto/substrait/algebra.proto | 4 ++-- site/docs/relations/logical_relations.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/proto/substrait/algebra.proto b/proto/substrait/algebra.proto index 83c1912c4..6c68f19dd 100644 --- a/proto/substrait/algebra.proto +++ b/proto/substrait/algebra.proto @@ -86,10 +86,10 @@ message ReadRel { substrait.extensions.AdvancedExtension advanced_extension = 10; } - // A table composed of literals. + // A table composed of expressions. message VirtualTable { repeated Expression.Literal.Struct values = 1 [deprecated = true]; - repeated Expression expression_values = 2; + repeated Expression expressions = 2; } // A stub type that can be used to extend/introduce new table types outside diff --git a/site/docs/relations/logical_relations.md b/site/docs/relations/logical_relations.md index 432a3a3b6..86e68c9e0 100644 --- a/site/docs/relations/logical_relations.md +++ b/site/docs/relations/logical_relations.md @@ -51,7 +51,7 @@ Read definition types (like the rest of the features in Substrait) are built by #### Virtual Table A virtual table is a table whose contents are embedded in the plan itself. The table data -is encoded as records consisting of literal values or an expression that can be resolved without referencing any input data. +is encoded as records consisting of literal values or expressions that can be resolved without referencing any input data. For example, a literal, a function call involving literals, or any other expression that does not require input.