From 3175d0079f12200065ac3a75fa54b35e00851868 Mon Sep 17 00:00:00 2001
From: Jacques Nadeau <jacques@apache.org>
Date: Wed, 7 Aug 2024 16:55:08 -1000
Subject: [PATCH] Address review comments.

---
 proto/substrait/algebra.proto | 5 ++---
 proto/substrait/type.proto    | 4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/proto/substrait/algebra.proto b/proto/substrait/algebra.proto
index 70c22e6fb..b335b5f43 100644
--- a/proto/substrait/algebra.proto
+++ b/proto/substrait/algebra.proto
@@ -883,14 +883,13 @@ message Expression {
       int32 days = 1;
       int32 seconds = 2;
 
-      // oneof ensures that a user can only use precision (and subseconds) or microseconds
       oneof precision_mode {
         int32 microseconds = 3 [deprecated = true]; // use precision and subseconds below, they cover and replace microseconds.
-        // Sub-second precision, 0 means the value given is in seconds, 3 is milliseconds, 6 microseconds, 9 is nanoseconds.
+        // Sub-second precision, 0 means the value given is in seconds, 3 is milliseconds, 6 microseconds, 9 is nanoseconds. Should be used with subseconds below.
         int32 precision = 4;
       }
 
-      // the number of fractional seconds using  1e(-precision) units. Should be ignored if microseconds is set above.
+      // the number of fractional seconds using 1e(-precision) units. Should only be used with precision field, not microseconds.
       int64 subseconds = 5;
     }
 
diff --git a/proto/substrait/type.proto b/proto/substrait/type.proto
index a3fd78e53..19e49588a 100644
--- a/proto/substrait/type.proto
+++ b/proto/substrait/type.proto
@@ -135,11 +135,11 @@ message Type {
     Nullability nullability = 2;
 
     // Sub-second precision, 0 means the value given is in seconds, 3 is milliseconds, 6 microseconds, 9 is nanoseconds, etc.
-    // if unset, treat as 6. this allows non-backwards breaking change
+    // if unset, treat as 6.
     optional int32 precision = 3;
   }
 
-  // An interval consisting of months, days, and nanoseconds
+  // An interval consisting of the components of both IntervalMonth and IntervalDay
   message IntervalCompound {
     uint32 type_variation_reference = 1;
     Nullability nullability = 2;