Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_substrait does not support DELIM_JOIN #117

Open
3 tasks done
EpsilonPrime opened this issue Nov 8, 2024 · 1 comment
Open
3 tasks done

get_substrait does not support DELIM_JOIN #117

EpsilonPrime opened this issue Nov 8, 2024 · 1 comment

Comments

@EpsilonPrime
Copy link
Member

The substrait integration is experimental. Support is currently only available on request.

  • I have permission to ask for support.

What happens?

If you pass TPC-H query 2 to get_substrait() it complains that DELIM_JOIN Is not supported.

To Reproduce

install substrait;
load substrait;
install tpch;
load tpch;

.width -1
.mode csv
select query from tpch_queries() where query_nr=2;

FROM get_substrait("SELECT
      s_acctbal,
      s_name,
      n_name,
      p_partkey,
      p_mfgr,
      s_address,
      s_phone,
      s_comment
  FROM
      part,
      supplier,
      partsupp,
      nation,
      region
  WHERE
      p_partkey = ps_partkey
      AND s_suppkey = ps_suppkey
      AND p_size = 15
      AND p_type LIKE '%BRASS'
      AND s_nationkey = n_nationkey
      AND n_regionkey = r_regionkey
      AND r_name = 'EUROPE'
      AND ps_supplycost = (
          SELECT
              min(ps_supplycost)
          FROM
              partsupp,
              supplier,
              nation,
              region
          WHERE
              p_partkey = ps_partkey
              AND s_suppkey = ps_suppkey
              AND s_nationkey = n_nationkey
              AND n_regionkey = r_regionkey
              AND r_name = 'EUROPE')
  ORDER BY
      s_acctbal DESC,
      n_name,
      s_name,
      p_partkey
  LIMIT 100;
  "
  );

The result is:

INTERNAL Error: DELIM_JOIN

OS:

MacOS

Substrait-Extension Version:

v0.10.1 4a89d97db8

DuckDB Version:

v0.10.1 4a89d97db8

DuckDB Client:

CLI

Have you tried this on the latest master branch?

  • I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

  • I agree
@EpsilonPrime
Copy link
Member Author

EpsilonPrime commented Nov 8, 2024

Define sideband optimization hints #705 was added to the specification to help support the required feature on the DuckDB side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant