New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import types from type-definitions #533

Closed

jiqiang90 opened this issue Oct 15, 2021 · 1 comment

Labels

Contributor

jiqiang90 commented Oct 15, 2021

Allow us to import types from "@xxx-network/type-definitions"

In manifest v2, assume we allow user pass the network name we could look up types from here
https://github.com/polkadot-js/apps/blob/master/packages/apps-config/src/api/spec

Also, remain the current approach, allow user to override the types

jiqiang90 added the P5-nicetohave label

jiqiang90 closed this as completed

Contributor Author

jiqiang90 commented Oct 15, 2021

In manifest v2, we already support import type from .json, so this is alternative approach.
#495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment