Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password input breaks normal input #6571

Open
neomasterr opened this issue Dec 25, 2024 · 2 comments
Open

Password input breaks normal input #6571

neomasterr opened this issue Dec 25, 2024 · 2 comments

Comments

@neomasterr
Copy link

neomasterr commented Dec 25, 2024

Description of the bug

Bottom input field is preserving password state

Steps to reproduce

  1. Somehow you need to open password input, in my case i upload file via sftp with entering ssh key passphrase
image
  1. Finish input
  2. Try rename files or create branches or anything
    image
    image

Expected behavior

input should reset it's state to "text input" and show characters

Actual behavior

input stays in "password" state and doesn't show characters

Sublime Text build number

4189

Operating system & version

Windows 11

(Linux) Desktop environment and/or window manager

No response

Additional information

No response

OpenGL context information

No response

@keith-hall
Copy link
Collaborator

Presumably the plugin you are using sets the password setting directly on the input panel's view and doesn't clear it afterwards. The view is reused for all input panels in the same window.
Probably it would be more correct for it to have a dummy password syntax with syntax specific settings for "password": true, and apply the syntax to the input panel view. Then, if/when another plugin shows an input panel, ST would reset it to plain text syntax and it would lose the password marking automatically...

@neomasterr
Copy link
Author

neomasterr commented Dec 27, 2024

It broke since 4186 version
Plugin i use is SFTP
My thoughts is panel input not forcing "input type: text" when rendered. Maybe it still SFTP fault, but in previous Sublime Text versions it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants