Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] (PR provided) End of regex sometimes interpreted as comment #894

Closed
Thom1729 opened this issue Apr 11, 2017 · 0 comments
Closed

Comments

@Thom1729
Copy link
Collaborator

Tests:

'// /* /**';
//^^^^^^^^^^ - comment

"// /* /**";
//^^^^^^^^^^ - comment

/test// 1;
// <- string.regexp.js
//    ^ keyword.operator.arithmetic.js

/test/* 1;
// <- string.regexp.js
//    ^ keyword.operator.arithmetic.js
// */

/test/** 1;
// <- string.regexp.js
//    ^^ keyword.operator.arithmetic.js
// */

In the syntax, the comments context is manually included in over twenty places. Presumably, this is a relic of the syntax's heritage as a .tmLanguage, which didn't support prototype contexts. Updating this is a step toward fixing #885, and this bug can be fixed in the process.

@Thom1729 Thom1729 changed the title [JavaScript] End of regex sometimes interpreted as comment [JavaScript] (PR provided) End of regex sometimes interpreted as comment Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant