Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart space before #19

Closed
koppor opened this issue Aug 7, 2024 · 3 comments
Closed

Smart space before #19

koppor opened this issue Aug 7, 2024 · 3 comments
Assignees

Comments

@koppor
Copy link
Collaborator

koppor commented Aug 7, 2024

Note: I call the action to insert a citation in the form [1] ACTiON, since the buttons are currently wrong. See. #13.

  1. User types spaces
  2. User triggers ACTION
  3. [1] should be inserted. (With 1 being a representative of the "right" number)

Actual result: [1] inserted.

I know, I asked for "space before". I did not unzip.

If it is not possible to check if a space is before the cursor and handle accordingly, please do not insert any space.

@subhramit
Copy link
Owner

subhramit commented Aug 7, 2024

Okay, tricky one. I will remove the proceeding space and keep this issue open if we figure out that there is a smart way to do this.

@subhramit subhramit self-assigned this Aug 7, 2024
@subhramit
Copy link
Owner

Okay, tricky one. I will remove the proceeding space and keep this issue open if we figure out that there is a smart way to do this.

Scratch that, there was.
Implemented smart spaces till 1 extra space :)

@koppor
Copy link
Collaborator Author

koppor commented Aug 7, 2024

I checked. Thank you!

I improved it to NOT insert a space after. Reason: Typically, a citation ends a sentence. Deletion of a character is more work.

@koppor koppor closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants