Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigation: can't upgrade Acorn to 7.x #1457

Closed
sapegin opened this issue Oct 28, 2019 · 2 comments
Closed

Investigation: can't upgrade Acorn to 7.x #1457

sapegin opened this issue Oct 28, 2019 · 2 comments

Comments

@sapegin
Copy link
Member

sapegin commented Oct 28, 2019

I'm trying to upgrade Acorn from 6.30 to 7.0.0 (or 7.1.0) and it doesn't work:

SyntaxError: Unexpected token (1:6)
1 : <React.Fragment><Button>Push Me</Button></React.Fragment>;
          ^
SyntaxError: Unexpected token (3:15)
1 : import Placeholder from '../Placeholder'
2 : ;<Button>
3 :   <Placeholder />
                   ^

I don't see any migration guide or changes that may break JSX parsing. Any hints would be great here.

@malyzeli
Copy link

Probably related to #1321

@sapegin
Copy link
Member Author

sapegin commented Oct 29, 2019

@malyzeli I think you're right, closing this one as duplicate.

@sapegin sapegin closed this as completed Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants