Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin no longer transforming codebase as of v1.10.3 #243

Open
frisbee09 opened this issue Aug 27, 2019 · 4 comments
Open

Plugin no longer transforming codebase as of v1.10.3 #243

frisbee09 opened this issue Aug 27, 2019 · 4 comments

Comments

@frisbee09
Copy link

Just updated from v1.10.0 to v1.10.6 and finding the plugin no longer transforming any of my code. I managed to get it to kick back in by downgrading to v1.10.2.

My snapshots capture this by failing with these kinds of mismatches,

 -           "componentId": "ComponentName___default-sc-15na3pr-0", /// v1.10.2 with RHL
 +           "componentId": "ComponentName-sc-15na3pr-0", //v1.10.2 without RHL
 +           "componentId": "sc-bdVaJa", //v1.10.3+

If it helps debug the issue, I can confirm that the ___default injection appears when react-hot-loader/babel is enabled. Removing react-hot-loader from the plugin chain doesn't make [email protected] transform any of my code, however.

Babel configuration looks like this:

{
	"plugins": [
		"babel-plugin-styled-components",
		"@babel/plugin-proposal-class-properties",
		"@babel/plugin-transform-runtime",
		"@babel/plugin-transform-object-assign",
		"@babel/plugin-proposal-throw-expressions",
		"@babel/plugin-transform-react-constant-elements",
		"react-hot-loader/babel"
	],
	"presets": [
		[
			"@babel/preset-env",
			{
				"targets": {
					"ie": "11"
				}
			}
		],
		"@babel/preset-react",
		"@babel/preset-typescript"
	]
}

Sorry if this is a bad bug report? I'm not used to opening GitHub issues. Could this be related to @babel/plugin-proposal-dynamic-import becoming part of @babel/core as of v7.5.0?

@AndyBan
Copy link

AndyBan commented Sep 11, 2019

👍 We are seeing the same issue

@ppiyush13
Copy link

ppiyush13 commented Sep 22, 2019

Same issue with version 1.10.6, everything works with 1.10.5.
.babelrc content:

{
    "presets": ["@babel/env"],
    "plugins": [
        [
            "babel-plugin-styled-components",
            {
                "minify": true,
                "transpileTemplateLiterals": true,
                "fileName": false,
                "displayName": true,
                "ssr": false
            }
        ]
    ]
}

@Shakeskeyboarde
Copy link

Same issue here.

@frisbee09
Copy link
Author

There is a potential fix for you in #261 @ChrisAckerman @AndyBan @ppiyush13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants