-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor media API into multiple modules #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! It's hard to get to each TODO I write, so I really appreciate you knocking it out. I didn't look too closely at the existing and relocated code, I'm going to trust it was moved without edits which seems to be the case for the handful I did scan through. I had a couple of unimportant questions, but they aren't blocking.
Oh I also renamed the PR to have more contextual meaning
Okay I think that fix addresses the only issue here. I'll let CI finish then merge late tonight unless you indicate otherwise. |
This is just a reorganization pull request, it does what a TODO comment suggested and removes everything in the (very large) single-file
media.rs
module out to a directory and separates the bulk, individual, and thumbnail operations.It also removes all the
apply_*
filters frommedia
and into a separatefilters
module (again, as suggested by the TODO). I also did the same for other such functions in other places to keep things organized.