From dc3003f2663dcca503766ca94186d8e40ac2b1ef Mon Sep 17 00:00:00 2001 From: Aaron Leopold <36278431+aaronleopold@users.noreply.github.com> Date: Wed, 21 Aug 2024 12:21:41 -0700 Subject: [PATCH] :bug: Fix book titles in entity cards The filename was being displayed instead of prioritizing the `title` from metadata (if present) --- apps/expo/src/components/book/BookListItem.tsx | 2 +- packages/browser/src/components/book/BookCard.tsx | 2 +- packages/browser/src/scenes/book/BookOverviewScene.tsx | 4 ++-- packages/browser/src/scenes/book/DownloadMediaButton.tsx | 6 ++++-- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/apps/expo/src/components/book/BookListItem.tsx b/apps/expo/src/components/book/BookListItem.tsx index 42b8300d2..f5502e113 100644 --- a/apps/expo/src/components/book/BookListItem.tsx +++ b/apps/expo/src/components/book/BookListItem.tsx @@ -24,7 +24,7 @@ export const BookListItem = React.memo(({ book, navigate }: BookListItemProps) = style={{ height: 50, objectFit: 'scale-down', width: 50 / (3 / 2) }} /> - {book.name} + {book.metadata?.title || book.name} )) diff --git a/packages/browser/src/components/book/BookCard.tsx b/packages/browser/src/components/book/BookCard.tsx index 3e1a5e4ae..eed593295 100644 --- a/packages/browser/src/components/book/BookCard.tsx +++ b/packages/browser/src/components/book/BookCard.tsx @@ -143,7 +143,7 @@ export default function BookCard({ return ( { return (
- {media.name} + {media.metadata?.title || media.name} - Stump | {media.name || ''} + Stump | {media.metadata?.title || media.name || ''}
diff --git a/packages/browser/src/scenes/book/DownloadMediaButton.tsx b/packages/browser/src/scenes/book/DownloadMediaButton.tsx index 856733bd4..9f3804dcf 100644 --- a/packages/browser/src/scenes/book/DownloadMediaButton.tsx +++ b/packages/browser/src/scenes/book/DownloadMediaButton.tsx @@ -10,16 +10,18 @@ type Props = { export default function DownloadMediaButton({ media }: Props) { const isAtLeastMedium = useMediaMatch('(min-width: 768px)') + const bookTitle = media.metadata?.title || media.name + const renderButton = () => { if (isAtLeastMedium) { return ( - + ) } else { return ( - )