Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Make bundled web app a PWA #570

Merged
merged 4 commits into from
Jan 25, 2025
Merged

✨ Make bundled web app a PWA #570

merged 4 commits into from
Jan 25, 2025

Conversation

aaronleopold
Copy link
Collaborator

Resolves #189
Resolves #568

This PR uses vite-plugin-pwa to make the web app PWA-compatible. There are some changes still required to support serving the new assets, however this is pretty close. I'll also note that this doesn't enable any real offline features, e.g. fully offline reading. These changes enable you to install the web app as a PWA.

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
apps/server/src/routers/spa.rs 11.53% <ø> (+1.86%) ⬆️

@aaronleopold aaronleopold marked this pull request as ready for review January 25, 2025 19:25
@aaronleopold aaronleopold merged commit c957fd3 into develop Jan 25, 2025
9 checks passed
@aaronleopold aaronleopold mentioned this pull request Feb 2, 2025
@aaronleopold aaronleopold deleted the al/vite-pwa branch February 14, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant