🐛 Remove auto-pagination for usePageQuery wrapper
#564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user reported missing libraries in their sidebar, since it was capped at 20 I knew exactly where to look. The `usePageQuery` wrapper function I created auto adds page details to the request, but the sidebar assumes unpagination responses . The long term fix will be to implement cursor fetching as you scroll the sidebar, but this should do for now. I dont have time to test right away
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported missing libraries in their sidebar, since it was capped at 20 I knew exactly where to look. The
usePageQuerywrapper function I created auto adds page details to the request, but the sidebar assumes unpaginated responses. The long term fix will be to implement cursor fetching as you scroll the sidebar, but this should do for now.I don't have time to test right away, but I'll try to poke around and make sure this doesn't inadvertently break something else.