Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OPDS Catalog Fails to Display #513

Closed
kulak opened this issue Dec 8, 2024 · 4 comments · Fixed by #519
Closed

[BUG] OPDS Catalog Fails to Display #513

kulak opened this issue Dec 8, 2024 · 4 comments · Fixed by #519
Labels
bug Something isn't working

Comments

@kulak
Copy link

kulak commented Dec 8, 2024

Description of the Bug

Open URL for OPDS. Example: http://10.0.1.4:1801/opds/v1.2/catalog

HTML Response Body Contains Message:

Wrong number of path arguments for Path. Expected 1 but got 0. Note that multiple parameters must be extracted with a tuple Path<(_, _)> or a struct Path<YourParams>

Expected Behavior

Expected catalog content.

To Reproduce

I used podman configuration pointing directly to v0.0.8. I added discussion on this topic #512

# to run rootless on podman, put this is 
#     $USER/.config/containers/systemd/stump.container
# file and then run
#    systemctl --user daemon-reload
#    systemctl --user start stump.service

[Unit]

Description=stump

[Container]

Image=docker.io/aaronleopold/stump:0.0.8

UserNS=keep-id

# Volume Mapping: host:container:options
# host directories must exist and be owned by $USER
Volume=/data/Family/Books:/data:Z
Volume=/var/lib/family/.config/stump:/config:Z

# port mapping: host:container
PublishPort=1801:10801

# entry point script does too much, run directly
WorkingDir=/app
Entrypoint=/app/stump

[Service]

# https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Restart=
Restart=no

# Extend Timeout to allow time to pull the image
TimeoutStartSec=10

[Install]

# Start by default on boot, make sure to enable linger with 
#     loginctl enable-linger $USER
#
WantedBy=multi-user.target default.target

Environment:

  • OS: Fedora 41
  • Device: Firefox current version of browser on Fedora 41

Build Details:

  • Version: 0.0.8,
  • Docker: yes, podman

Semantic version: v0.0.8
Exact commit: 2c0208c
Build date: December 3, 2024 4:43 PM

@aaronleopold
Copy link
Collaborator

Thanks for bringing this to my attention! Unfortunate this slipped through the cracks for a few weeks that it sat in the nightly build, but happy it was eventually caught nonetheless.

I've seemingly fixed it locally and pushed the changes up if you look at the linked PR. I've added a debug commit to push a opds-path-error-patch image through CI. It should be up any minute. If you can validate that corrects the issue on your end, I'll release a 0.0.9 tomorrow to patch the latest tag

@kulak
Copy link
Author

kulak commented Dec 8, 2024

Thanks for bringing this to my attention! Unfortunate this slipped through the cracks for a few weeks that it sat in the nightly build, but happy it was eventually caught nonetheless.

I've seemingly fixed it locally and pushed the changes up if you look at the linked PR. I've added a debug commit to push a opds-path-error-patch image through CI. It should be up any minute. If you can validate that corrects the issue on your end, I'll release a 0.0.9 tomorrow to patch the latest tag

I used

Image=docker.io/aaronleopold/stump:opds-path-error-patch

It seems to work now:

image

@aaronleopold
Copy link
Collaborator

It seems to work now

Awesome! Thanks for validating the image. I'll update this issue once the fix is fully released tomorrow

aaronleopold added a commit that referenced this issue Dec 8, 2024
Fixes #513

This was a classic instance of organizing the router layers incorrectly, so the API key middleware was being run for both variants of the router instead of just when the `:api-key` path hits a match.

This is a pretty large bug that somehow went missed for the 3-4 weeks this sat in the nightly image lol I'll release `0.0.9` as a hotfix ideally tomorrow
@aaronleopold
Copy link
Collaborator

The fix is in nightly and will make its way to latest once the 0.0.9 build completes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants