Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Create Preformatted component to render JSON #505

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

xendke
Copy link
Contributor

@xendke xendke commented Nov 12, 2024

Noticed <pre> being used in a couple of places. This PR introduces a reusable component for those use cases!

Also found that a random modal was not closing in certain cases so I fixed that as well.

Some uses of the new component:

Screenshot 2024-11-11 210033
Screenshot 2024-11-11 210247
Screenshot 2024-11-11 215432

Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will merge this once the existing promotion experimental->develop PR is merged

@aaronleopold aaronleopold merged commit d744f66 into stumpapp:experimental Nov 18, 2024
6 checks passed
@aaronleopold aaronleopold mentioned this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants