-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Improve documentation to describe how to setup task scheduler #4
Comments
I think the manager system could be entirely replaced with the |
I took some time to look through this. It looks like it could technically work, but I am not sure I want to get this package into the complexity of task management. That said, if this is a feature that users are requesting/will find valuable, we could look into it further. Some initial requirements up front:
Two ways to meet the above requirements off the top of my head:
From a personal perspective, this is not something I am going to have time to implement robustly, so I probably am not going to do this. If you (or anyone else) is interested in taking this up, we can chat further on this issue here and determine the best approach (i.e. I don't want anyone to do all this work and then have the pull request rejected). |
From my perspective, as a user of this library, it is definitely better to just let the library process events and notifying relevant manager functions than having to set-up and maintain my own schedule system; which is usually Cron on Linux having a precision of 1 minute - it means you can't be sure your task runs on the required second, only at the same minute without using Cron hacks. It doesn't have to be optional; In fact, we could use it as the main way to run the Manager and deprecate the old system for backward compatibility. Most of the system would be untouched - The same Manager that should be extended with the same event functions. We only have to do these things:
And it should do it, at least minimally to get it working. |
I'll open a new issue because this one isn't relevant. |
Update documentation to describe how to setup and integrate application with a task scheduler (e.g. Celery).
The text was updated successfully, but these errors were encountered: