propagate popup events up through the marker component #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for vue-mapbox-gl pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for vue-mapbox-gl-demo canceled.
|
|
Another nice to have (not sure how to implement in your code base - sorry). If MapboxPopup.vue had an extra property |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - thanks for the code!
This is a small change to propagate the popup events up through the marker component. Not sure if it's the best way to do it and I had to disable the emit in the popup class (line 96) to stop the open event on load.
Hope you can include it!