From 766b1deb4989331c0229272be2b67af14164b23b Mon Sep 17 00:00:00 2001 From: "Dr. Stefan Schimanski" Date: Wed, 19 Apr 2017 17:35:35 +0200 Subject: [PATCH] REVISIT/TODO: fix-test: semantic equality for pkg/deploy roundtrip tests --- pkg/deploy/api/v1/defaults_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/deploy/api/v1/defaults_test.go b/pkg/deploy/api/v1/defaults_test.go index b8a642a86a27..949382e5eb7c 100644 --- a/pkg/deploy/api/v1/defaults_test.go +++ b/pkg/deploy/api/v1/defaults_test.go @@ -557,7 +557,8 @@ func TestDefaults(t *testing.T) { t.Errorf("unexpected object: %v", got) t.FailNow() } - if !reflect.DeepEqual(got.Spec, expected.Spec) { + // TODO(rebase): check that there are no fields which have different semantics for nil and [] + if !kapi.Semantic.DeepEqual(got.Spec, expected.Spec) { t.Errorf("got different than expected:\nA:\t%#v\nB:\t%#v\n\nDiff:\n%s\n\n%s", got, expected, diff.ObjectDiff(expected, got), diff.ObjectGoPrintSideBySide(expected, got)) } }