Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config injection): remove Config from the DI tokens #1389

Merged
merged 6 commits into from
Feb 12, 2019

Conversation

simondel
Copy link
Member

BREAKING CHANGE: removed Config object from Dependency Injection (only relevant for plugin creators).

@ghost ghost assigned simondel Feb 12, 2019
@ghost ghost added the 🔎 Needs review label Feb 12, 2019
@nicojs nicojs merged commit 6561841 into v1 Feb 12, 2019
@nicojs nicojs deleted the remove-config-token branch February 12, 2019 12:06
@ghost ghost removed the 🔎 Needs review label Feb 12, 2019
nicojs pushed a commit that referenced this pull request Feb 12, 2019
BREAKING CHANGE: removed Config object from Dependency Injection (only relevant for plugin creators).
nicojs pushed a commit that referenced this pull request Feb 12, 2019
BREAKING CHANGE: removed Config object from Dependency Injection (only relevant for plugin creators).
nicojs pushed a commit that referenced this pull request Feb 13, 2019
BREAKING CHANGE: removed Config object from Dependency Injection (only relevant for plugin creators).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants