Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hit counter in the jasmine-runner #3173

Closed
nicojs opened this issue Sep 30, 2021 · 3 comments
Closed

Implement hit counter in the jasmine-runner #3173

nicojs opened this issue Sep 30, 2021 · 3 comments
Labels
🚀 Feature request New feature request hacktoberfest https://hacktoberfest.digitalocean.com/

Comments

@nicojs
Copy link
Member

nicojs commented Sep 30, 2021

Implement the hit counter for Jasmine 🟣. This is to prevent infinite loops from resulting in a timeout, see #3023.

@nicojs nicojs added 🚀 Feature request New feature request hacktoberfest https://hacktoberfest.digitalocean.com/ labels Sep 30, 2021
@fredericbonnet
Copy link
Contributor

I've implemented the feature in PR #3199. The required changes were close to what I've already done for mocha-runner in PR #3193. One notable exception is the behavior of MutantRunOptions.testFilter:

  • karma-runner and mocha-runner apply the filter on test descriptions
  • jasmine-runner applies the filter on test IDs

Test file timeout-on-infinite-loop.it.spec.ts is a good illustration. I haven't found any doc or explanation on the expected behavior of this flag, but in any case aligning jasmine-runner on (karma|mocha)-runner doesn't look too difficult.

@nicojs
Copy link
Member Author

nicojs commented Oct 25, 2021

Fixed with #3199

@nicojs nicojs closed this as completed Oct 25, 2021
@nicojs
Copy link
Member Author

nicojs commented Nov 23, 2021

This feature was released in StrykerJS 5.5, see https://twitter.com/stryker_mutator/status/1463193766982995978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Feature request New feature request hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

No branches or pull requests

2 participants